Closed amtoine closed 10 months ago
IogaMaster
commented
10 months ago Simple setup of a reproducable development environment, same version of rust toolchain and nushell for development.
As well as simple remote testing.
With nix run: nix run github:nushell/nufmt and the version on main will be built without any installation of rust.
Also makes this package play with nix better. Making packaging in nixpkgs simple.
amtoine
commented
10 months ago i get it but my main question remains: do we need to have that in nufmt?
it's just that i personally do not know anything about all this, even though i really want to try NixOS, and we already have #53 but i'm not sure we have anyone to answer this :confused:
IogaMaster
commented
10 months ago It's not integrated into nufmt, it's around to make working on it easier.
One other thing, we can cross compile nufmt for any platform and architecture. Which make building github releases ci easier.
amtoine
commented
10 months ago could we put these files into a nix/ directory at the root of the repo? :innocent:
consider me as a total newbie when it comes to nix :relieved:
IogaMaster
commented
10 months ago Unfortunately the flake.nix must go in the root of the repo. That is the standard for flakes.
fdncred
commented
10 months ago I don't see what the problem is. Who cares that there is a flake.nix/.lock file in the root of the repo. It just helps people who use nix to be able to test/use it. It seems like a big waste of time to debate trivial changes like this.
amtoine
commented
10 months ago thanks @IogaMaster for explaining why these have been added the way they have been :pray:
related to
41
cc/ @IogaMaster
Description of changes
this PR reverts #41.
without any justification for this, i'd rather revert the changes :yum: i'm still having issues understanding what this does and why we need that in Nufmt when we don't even have a working MVP of the formatter itself :thinking: