nushell / nufmt

MIT License
64 stars 8 forks source link

Move Nix-related files to nushell/integrations #58

Open kubouch opened 6 months ago

kubouch commented 6 months ago

Is your feature request related to a problem? Please describe.

We recently set up a community maintained https://github.com/nushell/integrations to keep package manager and other integration files for Nushell projects there. The intent is to avoid cluttering our repositories with 3rd party tool files that the core team has to maintain.

Describe the solution you'd like

Move Nix-related files to https://github.com/nushell/integrations

Describe alternatives you've considered

Since the core team doesn't actively develop nufmt (yet?), it depends on the active nufmt developers if they want these in and maintain them. But once we scale up the development, we might move them, since that's the direction we've followed in Nushell itself and recently nupm.

amtoine commented 6 months ago

sounds very nice to have everything centralized into once place

amtoine commented 6 months ago

i don't know if simply moving flake.nix and flake.lock to a new nufmt/ directory in nushell/integrations would be enough?

kubouch commented 6 months ago

I'm thinking a better idea would be to have a directory per package manager. I imagine package managers could reuse some files between projects, or have a top-level Nushell package with nupm/nufmt/... as its sub-packages. So it could look something like

nushell/integrations
+-- apt/
      +-- nufmt/
      +-- nupm/
      +-- nushell/
      +-- common-stuff/
+-- nix/
      +-- nufmt/
      +-- nupm/
      +-- nushell/
      +-- common-stuff/

Note that just copy-pasting the current flake files (the .envrc has some nix stuff in it as well) to nushell/integrations won't work, the flake would need to change to fetch nufmt from GitHub instead of building from local file tree.

amtoine commented 6 months ago

yup, all of this makes perfect sense :ok_hand:

AucaCoyan commented 6 months ago

Yes! I completely agree!