search

nushell / nufmt

MIT License
71 stars 10 forks source link

Actually read from stdin #61

Closed NomisIV closed 3 months ago

NomisIV commented 3 months ago

Description of changes

--stdin flag read a command line argument, not stdin. Now it reads from stdin.

Not sure if my code would compile on windows, but I don't have a windows computer to test it.

I'm aware that https://github.com/nushell/nufmt/pull/57 tries to solve this as well, but it seems stagnant and won't pass CI.

Relevant Issues

https://github.com/nushell/nufmt/issues/56

fdncred commented 3 months ago

Seems reasonable. Is there a way to add a test for this?

AucaCoyan commented 3 months ago

Hi! It does work on Windows 😊. I tried to do it with a library in #57 , but I couldn't in few tries. This version with no added dependencies is what I inteded to do in the first place 🙌

fdncred commented 3 months ago

Thanks