nushell / nushell.github.io

Nushell's main website, blog, book, and more
https://www.nushell.sh/book/
MIT License
162 stars 400 forks source link

Lang guide refactor #1403

Closed NotTheDr01ds closed 1 month ago

NotTheDr01ds commented 1 month ago

Based on a discussion in the Website/Doc Discord channel yesterday. This is an extensive refactor of the monolithic Language Guide into smaller, individual files that can be more easily edited and merged.

This has the added advantage of properly styling headings in the sub-files.

During this refactor, I did make a few other tweaks along the way:

I can back out any of these if there's disagreement - They just felt fairly safe and needed while I was creating the sub-files.

fdncred commented 1 month ago

What does this look like rendered. I don't see a TOC but maybe it's not supposed to have one?

NotTheDr01ds commented 1 month ago

What does this look like rendered. I don't see a TOC but maybe it's not supposed to have one?

Index/TOC is definitely on the TODO list. The sidebar looks great rendered - better than the existing, along with collapsibility for most sections.

I'd love to be able to enumerate subsections into the "overview" for each section, as well as a master index like we talked about.

I'm guessing there's some Vuepress support to automate this, but I haven't gone too deep yet.

If we're going to switch doc engines (since Vuepress is in maintenance mode) soon, it might make sense to wait until that decision is made. The more manually linking we do, the more chance for things to get out of sync, of course.

NotTheDr01ds commented 1 month ago

Also TODO (reminder to self) - more previous/next linking to aid with navigation/flow. I did a few that needed manual insertion of the YAML front-matter, but not all.

fdncred commented 1 month ago

Maybe this should be draft until it's finished?

NotTheDr01ds commented 1 month ago

Maybe this should be draft until it's finished?

It's already an improvement over what what was there, so I'd recommend going ahead with it so that we can do future merges on top of it. If anyone else wants to submit to the Guide in the meantime, it's going to be a very manual (copy/paste) merge process.

Once this refactor is in place, additional updates become much easier.

fdncred commented 1 month ago

ok, let's move forward with this. if we don't like it we can always roll back.

NotTheDr01ds commented 1 month ago

@fdncred Thanks! I'll try to keep close watch on any issues raised over the next few days. Feel free to ping me in Discord (better notifications) if you see anything.