nushell / nushell.github.io

Nushell's main website, blog, book, and more
https://www.nushell.sh/book/
MIT License
183 stars 431 forks source link

CORS preventing JQuery from loading, quick-docs fail to work #61

Closed ghost closed 2 years ago

ghost commented 4 years ago

As in title: I'm getting an error where CORS blocks JQuery so I can't browse the quick reference docs for the built-in commands. :/

jzaefferer commented 4 years ago

@cathalgarvey could you provide a screenshot or the exact error message? From DevTools console or network tab? A bit more detail would help a lot.

jzaefferer commented 4 years ago

Maybe related: https://www.nushell.sh/demo/ fails to load for me in Firefox, since it blocks Sentry from loading. Which causes the whole demo to fail, and the error isn't tracked.

In my case, the blocking is caused by a browser extension, uBlock origin. Without it, the demo works fine.

ghost commented 4 years ago

Sorry, missed the first request for info. I collected screenshots of the network and console panes which show that it's been blocked for CORS reasons, and the subsequent errors because $ is not defined.

I'm also using self-defence extensions including uMatrix, but I've already allowlisted JQuery in that plugin and checked the others for issues. The error messages appear to make it clear that it's caused by CORS.

nushell_docs_fail_console nushell_docs_fail_networkpane

rgwood commented 2 years ago

@cathalgarvey Thanks for reporting this and sorry for the very late reply. Closed as the website's been revamped and I don't think this will be an issue anymore. Feel free to comment here or open a new issue if you can still reproduce this.