Open RGBCube opened 6 months ago
The output of fish --command "complete '--do-complete=ffmpeg -i RGBCube.gif -crf'"
is this:
comfortnoise RFC 3389 comfort noise generator
dds DirectDraw Surface image decoder
derf_dpcm DPCM Xilam DERF
sunrast Sun Rasterfile image
And then you do the pipeline and get this:
╭───┬──────────────┬──────────────────────────────────╮
│ # │ value │ description │
├───┼──────────────┼──────────────────────────────────┤
│ 0 │ comfortnoise │ RFC 3389 comfort noise generator │
│ 1 │ dds │ DirectDraw Surface image decoder │
│ 2 │ derf_dpcm │ DPCM Xilam DERF │
│ 3 │ sunrast │ Sun Rasterfile image │
╰───┴──────────────┴──────────────────────────────────╯
Seems normal to me, the issue isn't in the completer?
What version of nushell are you running?
I've seen this ColumnarMenu
involved in panics a few times recently. @Tastaturtaste and @maxomatic458 have worked on menus most recently, maybe they have an idea?
i think it might be this line here: https://github.com/nushell/reedline/blob/0698712701418a7212ebf75d5724d72eccc4b43f/src/menu/columnar_menu.rs#L305
we could probably add a check there and if it fails we just dont style (looks like that can fail with some external completers)
ill try to make a PR for this later today
What version of nushell are you running?
I've seen this
ColumnarMenu
involved in panics a few times recently. @Tastaturtaste and @maxomatic458 have worked on menus most recently, maybe they have an idea?
0.90.1
@RGBCube can you try 0.91.1 and see if it's still there?
@RGBCube can you try 0.91.1 and see if it's still there?
Yes, the problem persists.
@maxomatic458 do you have time to look into fixing this or did I miss it already?
@fdncred https://github.com/nushell/reedline/pull/782 should fix this
Platform: Linux, NixOS Terminal software: Ghostty
I get this when I do
ffmpeg -i RGBCube.gif -crf
, assuming ffmpeg is installed.Here is a recording, but it doesn't show the trace as it appears for a split second: https://asciinema.org/a/oO8bzFkNpKFd3aFVq7Bfatr2d
The .cast file has it, though.
Here is my completer config:
Everything is from nixpkgs unstable.