search

nushell / reedline

A feature-rich line editor - powering Nushell
https://docs.rs/reedline/
MIT License
551 stars 155 forks source link

Fix case-consistency searching sqlite history #777

Closed sholderbach closed 8 months ago

sholderbach commented 8 months ago

After merging downstream will close https://github.com/nushell/nushell/issues/10131

For the FileBackedHistory those operations have always been case sensitive, do the same for SqliteBackedHistory. The insensitivity of like in sqlite causes https://github.com/nushell/nushell/issues/10131

Replace this with exact matching via sqlite's instr(), which should also fix a need for escaping of % (or * with glob)

fdncred commented 8 months ago

Cool! Seems good to be more consistent. Never heard of instr() before this.