search

nushell / reedline

A feature-rich line editor - powering Nushell
https://docs.rs/reedline/
MIT License
549 stars 154 forks source link

Different color struct #819

Open tisonkun opened 3 months ago

tisonkun commented 3 months ago

https://github.com/nushell/reedline/blob/020142f6ee857353c289119a04d8fc71c474ce59/src/prompt/base.rs#L100-L106

Why do we use different color struct for similar prompt color settings?

Is it still possible to align them?

sholderbach commented 3 months ago

That seems to be an oversight at some point. Not sure where the impact would be when changing to one or the other.

In general I am inclined to say we should simplify the prompt trait. In nushell most prompts do their own color ornamentation inside the prompt string so the whole notion of having prompt color(s) is a bit redundant.