Implemented VI mode change inside and delete inside functionality

nushell / reedline

A feature-rich line editor - powering Nushell

https://docs.rs/reedline/

MIT License

549 stars 155 forks source link

Implemented VI mode change inside and delete inside functionality #844

Closed ayax79 closed 1 month ago

ayax79 commented 1 month ago

This implements the change in (ci) and delete inside vi mode functionality:

ci" - Change in quotes
di" - Delete in quotes
ci[ - change in brackets

supports [ , ( , ", ', `, {

blindFS commented 1 month ago

I was waiting for this feature for long. It made me curious about the future plans for nushell repl parser/highlighter, are we going to use treesitter here in reedline in near future? Since without AST info, it's hard to deal with nasty cases where brackets get nested like (foo(bar "(" ) baz)

ayax79 commented 1 month ago

Another thing that should be addressed at some point.. Since this is basically supplying two actions, it requires two undo commands to get back to the previous state.