nusliuyifan / pe

0 stars 0 forks source link

Sample image didn't show up #1

Open nusliuyifan opened 5 months ago

nusliuyifan commented 5 months ago

1.ways to reproduce type in the same command as examples given in add part. add n/John Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01 g/johnDoee pp/https://api-prod-minimalv510.vercel.app/assets/images/avatar/avatar_1.jpg

2.expected outcome A new contact with an image(since there's pp/ in the example command then I will probably be expecting a sample image)

3.actual outcome A new contact shows up with no image

image.png

image.png

4.Add-on I take this as a fucntionality bug because the program doesn't work as said in the UG.

soc-se-bot commented 4 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Adding new contacts with PROFILE_PICTURE (pp)

I tried using the example command given: 'add n/John Doe p/98765432 e/johnd@example.com a/John street, block 123, #01-01 g/johnDoee pp/https://api-prod-minimalv510.vercel.app/assets/images/avatar/avatar_1.jpg'

Expected (From the UG):

image.png

Actual (From my screenshots):

image.png

It seems the problem might because My pc does not have the asset. No explanation about the profile picture too in the UG (so, it's hard to know what's wrong). There is an explanation that said it must be a valid URL to an image (is there any test check for this? throw an error message).


[original: nus-cs2103-AY2324S2/pe-interim#5223] [original labels: type.FunctionalityBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

hey there, a dash was missed out when you typed in the url! try this url instead

https://api-prod-minimal-v510.vercel.app/assets/images/avatar/avatar_1.jpg

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** The app didn't work as specified in the UG. The example given in UG didn't match the actual outcome. The team responded that we missed out a dash when typing the command, but the fact is that we just copy paste from the UG, so we think it's either a documentation problem or functionality bug.