nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
578 stars 315 forks source link

Improve UX of Timetable display filter #182

Closed tgxworld closed 9 years ago

tgxworld commented 9 years ago

screenshot from 2015-02-05 07 53 28

@yangshun Currently, disabled filters are highlighted while active filters are disabled. This seems counter intuitive to me. On top of that, the position of it is too far away from the actual calender.

What do you think about reversing the highlights and also moving it nearer to the calender?

yangshun commented 9 years ago

It's meant to look like that: http://getbootstrap.com/components/#btn-groups. The gray buttons are not disabled, they are being pressed.

I guess can make the active state as background orange with white text.

xinan commented 9 years ago

It is indeed quite counter intuitive. Maybe we should just reverse it?

xinan commented 9 years ago

Oh no, reversing it also won't work very well. Need to change some colors.

yangshun commented 9 years ago

This is the same issue iOS faced when iOS 7 first got released. In its control center, which icons are active?

iOS7 control center

iOS8 has changed it to:

iOS8 control center

But I don't find it much different. Lol.

xinan commented 9 years ago

Hahahaha I don't find that much different either. For our buttons, I had that thought last night when I saw this:

img_0262

yangshun commented 9 years ago

Yes that style is actually adopted for the semesters tabs at the top of the timetable page. Shall we change to that then?

On Sun, Mar 22, 2015 at 2:46 PM, Liu Xinan notifications@github.com wrote:

Hahahaha I don't find that much different either. For our buttons, I had that thought last night when I saw this:

[image: img_0262] https://cloud.githubusercontent.com/assets/2834397/6768374/0fb08462-d0a2-11e4-94ef-89150e625834.PNG

— Reply to this email directly or view it on GitHub https://github.com/nusmodifications/nusmods/issues/182#issuecomment-84535558 .

xinan commented 9 years ago

Ya the semesters tabs feel much better.

xbili commented 9 years ago

Closed via #205