nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
589 stars 320 forks source link

Use sass modules #2213

Open li-kai opened 5 years ago

li-kai commented 5 years ago

Is your feature request related to a problem? Please describe.

SASS has introduced a new feature called @use that does what we want instead of @import which is prone to duplicating styles.

https://css-tricks.com/introducing-sass-modules/

Describe the solution you'd like

Replace instances of using @import in most places with @use where possible.

e.g. @import '~styles/utils/modules-entry'; should be @use '~styles/utils/modules-entry';

Describe alternatives you've considered

NIL. I've not explored sass modules too much, but it looks powerful for other things than just importing.

Additional context

https://sass-lang.com/documentation/cli/migrator http://sass.logdown.com/

fernandacanepa commented 5 years ago

Hi! I read the link you left and indeed it looks powerful. All that you want here is to replace the @imports with @use? think I can do that haha

li-kai commented 5 years ago

Yes, that's all we want at the moment. I'll assign the issue if you want to take this up!

fernandacanepa commented 5 years ago

Yes, that's all we want at the moment. I'll assign the issue if you want to take this up!

Yass! I would like to take it!

li-kai commented 5 years ago

All yours! Thanks for volunteering for this. 😄