search

nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
586 stars 319 forks source link

Lessons starting before 8am #303

Closed li-kai closed 7 years ago

li-kai commented 8 years ago

What the bug causes is, it creates an additional row as it cannot find a slot to put the lesson in. E.g. MUA1109. As you try to drag and drop each time, a new row is created and never removed. Also, the lessons don't appear.

Here's the list of lessons starting before 0800:

[
 {
   "code": "BLD3003",
   "start_time": "07:00:00",
   "day_text": "SAT"
 },
 {
   "code": "BMA5901",
   "start_time": "06:00:00",
   "day_text": "SAT"
 },
 {
   "code": "BMA5901",
   "start_time": "07:00:00",
   "day_text": "SAT"
 },
 {
   "code": "BMA5902",
   "start_time": "06:00:00",
   "day_text": "SAT"
 },
 {
   "code": "ESE4502",
   "start_time": "07:00:00",
   "day_text": "TUE"
 },
 {
   "code": "ESE4502R",
   "start_time": "07:00:00",
   "day_text": "TUE"
 },
 {
   "code": "FE5110",
   "start_time": "06:00:00",
   "day_text": "SAT"
 },
 {
   "code": "MUA1109",
   "start_time": "06:00:00",
   "day_text": "SAT"
 },
 {
   "code": "MUA1109",
   "start_time": "06:30:00",
   "day_text": "SAT"
 },
 {
   "code": "MUA1109",
   "start_time": "07:00:00",
   "day_text": "SAT"
 },
 {
   "code": "MUA1109",
   "start_time": "07:30:00",
   "day_text": "SAT"
 },
 {
   "code": "MUA1109",
   "start_time": "06:00:00",
   "day_text": "FRI"
 },
 {
   "code": "MUA1161",
   "start_time": "06:30:00",
   "day_text": "FRI"
 },
 {
   "code": "MUA1161",
   "start_time": "07:00:00",
   "day_text": "THU"
 },
 {
   "code": "MUA1162",
   "start_time": "06:00:00",
   "day_text": "MON"
 },
 {
   "code": "MUA2110",
   "start_time": "06:00:00",
   "day_text": "MON"
 },
 {
   "code": "MUA2110",
   "start_time": "06:30:00",
   "day_text": "MON"
 },
 {
   "code": "MUA2110",
   "start_time": "07:00:00",
   "day_text": "MON"
 },
 {
   "code": "MUA2110",
   "start_time": "07:30:00",
   "day_text": "MON"
 },
 {
   "code": "MUA2162",
   "start_time": "06:00:00",
   "day_text": "SAT"
 },
 {
   "code": "MUA2162",
   "start_time": "06:00:00",
   "day_text": "MON"
 },
 {
   "code": "MUA3110",
   "start_time": "06:00:00",
   "day_text": "SAT"
 },
 {
   "code": "MUA3110",
   "start_time": "06:30:00",
   "day_text": "SAT"
 },
 {
   "code": "MUA3110",
   "start_time": "07:00:00",
   "day_text": "SAT"
 },
 {
   "code": "MUA3110",
   "start_time": "06:00:00",
   "day_text": "THU"
 },
 {
   "code": "MUA3110",
   "start_time": "07:30:00",
   "day_text": "SAT"
 },
 {
   "code": "MUA3131",
   "start_time": "07:30:00",
   "day_text": "WED"
 },
 {
   "code": "MUA3155",
   "start_time": "06:00:00",
   "day_text": "THU"
 },
 {
   "code": "MUA3161",
   "start_time": "07:30:00",
   "day_text": "FRI"
 },
 {
   "code": "MUA3161",
   "start_time": "07:00:00",
   "day_text": "FRI"
 },
 {
   "code": "MUA3255",
   "start_time": "06:00:00",
   "day_text": "MON"
 },
 {
   "code": "MUA4219",
   "start_time": "06:00:00",
   "day_text": "MON"
 },
 {
   "code": "MUA4219",
   "start_time": "06:00:00",
   "day_text": "WED"
 },
 {
   "code": "MUA4219",
   "start_time": "06:30:00",
   "day_text": "WED"
 },
 {
   "code": "MUA4219",
   "start_time": "07:00:00",
   "day_text": "WED"
 },
 {
   "code": "MUA4219",
   "start_time": "06:00:00",
   "day_text": "TUE"
 },
 {
   "code": "MUA4219",
   "start_time": "06:30:00",
   "day_text": "TUE"
 },
 {
   "code": "MUA4220",
   "start_time": "06:00:00",
   "day_text": "FRI"
 },
 {
   "code": "MUA4220",
   "start_time": "06:30:00",
   "day_text": "FRI"
 },
 {
   "code": "MUA4220",
   "start_time": "07:00:00",
   "day_text": "FRI"
 },
 {
   "code": "MUA4220",
   "start_time": "06:00:00",
   "day_text": "THU"
 },
 {
   "code": "MUA4220",
   "start_time": "07:30:00",
   "day_text": "THU"
 },
 {
   "code": "MUA4220",
   "start_time": "06:30:00",
   "day_text": "THU"
 },
 {
   "code": "MUA4228",
   "start_time": "06:30:00",
   "day_text": "TUE"
 },
 {
   "code": "MUA4228",
   "start_time": "06:00:00",
   "day_text": "WED"
 },
 {
   "code": "MUA4228",
   "start_time": "06:30:00",
   "day_text": "MON"
 },
 {
   "code": "MUA4228",
   "start_time": "06:00:00",
   "day_text": "TUE"
 },
 {
   "code": "MUA4228",
   "start_time": "06:00:00",
   "day_text": "THU"
 },
 {
   "code": "MUA4228",
   "start_time": "06:30:00",
   "day_text": "THU"
 },
 {
   "code": "MUA4228",
   "start_time": "07:00:00",
   "day_text": "THU"
 },
 {
   "code": "MUA4228",
   "start_time": "07:30:00",
   "day_text": "THU"
 },
 {
   "code": "MUA4228",
   "start_time": "06:00:00",
   "day_text": "FRI"
 },
 {
   "code": "MUA4229",
   "start_time": "06:00:00",
   "day_text": "TUE"
 },
 {
   "code": "MUA4229",
   "start_time": "06:30:00",
   "day_text": "WED"
 },
 {
   "code": "MUA4229",
   "start_time": "07:00:00",
   "day_text": "WED"
 },
 {
   "code": "MUA4229",
   "start_time": "07:30:00",
   "day_text": "WED"
 },
 {
   "code": "MUA4229",
   "start_time": "07:00:00",
   "day_text": "FRI"
 },
 {
   "code": "MUA4229",
   "start_time": "07:30:00",
   "day_text": "FRI"
 },
 {
   "code": "MUA4229",
   "start_time": "06:30:00",
   "day_text": "FRI"
 },
 {
   "code": "MUA4231",
   "start_time": "06:00:00",
   "day_text": "THU"
 },
 {
   "code": "MUA4232",
   "start_time": "06:30:00",
   "day_text": "THU"
 },
 {
   "code": "MUA5161",
   "start_time": "07:30:00",
   "day_text": "SAT"
 },
 {
   "code": "MUA6161",
   "start_time": "07:30:00",
   "day_text": "MON"
 },
 {
   "code": "MUA6161",
   "start_time": "07:30:00",
   "day_text": "MON"
 },
 {
   "code": "MUA6161",
   "start_time": "06:00:00",
   "day_text": "TUE"
 },
 {
   "code": "MUA6162",
   "start_time": "07:30:00",
   "day_text": "TUE"
 },
 {
   "code": "MUA6162",
   "start_time": "06:00:00",
   "day_text": "WED"
 },
 {
   "code": "MUA6162",
   "start_time": "06:30:00",
   "day_text": "TUE"
 },
 {
   "code": "MUA6162",
   "start_time": "06:30:00",
   "day_text": "WED"
 },
 {
   "code": "QF3312",
   "start_time": "06:00:00",
   "day_text": "SAT"
 },
 {
   "code": "TG3001",
   "start_time": "06:00:00",
   "day_text": "SAT"
 },
 {
   "code": "TG3101A",
   "start_time": "07:00:00",
   "day_text": "SAT"
 }
]
yangshun commented 8 years ago

Wew thanks for discovering this. We probably will not support this but instead we'll try to document these problems and try to fix them in v3. Would you like to collaborate on v3? 😄

li-kai commented 8 years ago

Yep, that's why I'm trying to learn react!

ngzhian commented 8 years ago

I'm hoping my team 3216's assignment code can be reused for v3 :) we have ~3 weeks till final submission, so hang tight :P

yangshun commented 8 years ago

I definitely hope so too. What I hope to happen is that we experiment with various implementations: modify.sg, nusmods-v3, Zhi An's momomods (3216 assignment), and we combine the lessons learnt and create the most badass timetable builder ever 🎉

yangshun commented 7 years ago

@li-kai This can be closed already right?

li-kai commented 7 years ago

Yep! Closed as this is solved in V3.