Closed EssWhyy closed 6 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nusmods-export | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 19, 2024 3:56pm |
nusmods-website | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 19, 2024 3:56pm |
@EssWhyy is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.
@nusmodifications first needs to authorize it.
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
84f4c5a
) 53.20% compared to head (a48a423
) 53.48%.
Files | Patch % | Lines |
---|---|---|
website/src/utils/timetables.ts | 92.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Context
Fix issue #3449
Implementation
Per the discussion in the issue, I added in an extra check in findExamClashes() in timetables.ts. The steps for this check are as follows:
The result can be seen here for both test cases:
Other Information
The current exam clash warning text can only show one date & time, as such for two exams with different start times, I used the earlier start time for the warning text as a workaround for now.
The function could probably be less verbose and more efficient. But on testing my end, there are no major slowdowns on the performance when adding or deleting a typical number of modules to the timetable.