nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
583 stars 316 forks source link

Fix `run-p` script glob on `yarn` 2+ #3611

Closed SuibianP closed 1 year ago

SuibianP commented 1 year ago

Context

Yarn 2+ expands glob patterns using its own shell and fails the lint script.

$ yarn --version
3.6.2
$ yarn run ci
No matches found: "lint:**"

No issue created due to its trivial nature.

Implementation

Quote the pattern to prevent premature expansion. Escaped double quotes are used for compatibility with cmd.exe.

Other Information

Related-Bug: mysticatea/npm-run-all#200 yarnpkg/berry#1814

Does the project officially support/plan to migrate to yarn 2+? If so, would it be better if such configuration is added to the test matrix?

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2023 5:54am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2023 5:54am
vercel[bot] commented 1 year ago

@SuibianP is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (b9d6038) 53.44% compared to head (c78e90a) 53.44%. Report is 1 commits behind head on master.

:exclamation: Current head c78e90a differs from pull request most recent head 0dce7f8. Consider uploading reports for the commit 0dce7f8 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3611 +/- ## ======================================= Coverage 53.44% 53.44% ======================================= Files 271 271 Lines 5862 5862 Branches 1396 1396 ======================================= Hits 3133 3133 Misses 2729 2729 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zwliew commented 1 year ago

Thank you! I haven't looked into yarn 2 yet but I'm open to the idea of upgrading to it. Someone just has to do it :P