nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
557 stars 270 forks source link

Add Timetable Reset Button #3643

Closed EssWhyy closed 5 months ago

EssWhyy commented 6 months ago

Context

Implements #3471

Implementation

Added a Reset Button to the timetable actions toolbar. This button will prompt a popup modal asking if the user wishes to reset the timetable to an empty state.

Clicking said button will call removeModule() across all modules in the given timetable prop for the current semester, thereby removing all modules and restting the timetable. resetTombstone() is also called once to remove the last module tombstone.

Video of UI and functionality:

https://github.com/nusmodifications/nusmods/assets/39799639/37cb1b9c-3da1-4fdf-87f9-b98bdac12915

Other Information

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 7:05am
vercel[bot] commented 6 months ago

@EssWhyy is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

EssWhyy commented 6 months ago

@joeng03 Thanks for the feedback. I was gonna work on refactoring it based on your suggestions but I see that you have already merged and implemented the improvements in your own branch above? I’ll leave you to merge it on your end then

joeng03 commented 6 months ago

I have opened the PR at #3646. Please help review and approve it

zwliew commented 5 months ago

Thanks for this; I'll close this PR and review just #3646.