search

nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
557 stars 270 forks source link

timetable: Add Timetable Reset Button #3646

Closed joeng03 closed 5 months ago

joeng03 commented 6 months ago

This PR is based on #3643, but with the implementation of a new removeModules action.

vercel[bot] commented 6 months ago

@joeng03 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 4:14am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 4:14am
EssWhyy commented 6 months ago

Seems like I can't approve the PR since I don't have write access to the main nusmods repo. Maybe can ask the core dev/admin team?

codecov[bot] commented 5 months ago

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (8f439cf) 53.25% compared to head (10de4c2) 53.20%.

Files Patch % Lines
website/src/reducers/timetables.ts 53.84% 6 Missing :warning:
website/src/views/timetable/ResetTimetable.tsx 58.33% 5 Missing :warning:
website/src/actions/timetables.ts 33.33% 2 Missing :warning:
website/src/views/timetable/TimetableContent.tsx 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3646 +/- ## ========================================== - Coverage 53.25% 53.20% -0.06% ========================================== Files 271 272 +1 Lines 5862 5885 +23 Branches 1396 1397 +1 ========================================== + Hits 3122 3131 +9 - Misses 2740 2754 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.