Closed EssWhyy closed 4 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nusmods-export | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 4, 2024 9:39am |
nusmods-website | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 4, 2024 9:39am |
@EssWhyy is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.
@nusmodifications first needs to authorize it.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.71%. Comparing base (
1ec2b2b
) to head (e156a0b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ooh just saw this :) thanks for implementing!
Just a note - pre-reqs that are not individual courses to begin with are also greyed out, like the one below:
@yimqiy thanks for the comment! I do think it makes sense to have different behaviour (i.e. don't just grey them out) for these non-course pre-req tree nodes -- let's track this as an issue
Context
Implements #3473
Implementation
Connects ModuleTree.tsx to the Redux Store, and uses the getModuleCondensed() function to check if the module code in each node points to a valid module in the current module bank. If the module has been deprecated, we remove the hoverable color-${layer} classname tag from the module node. The node will be greyed out and no longer appear hoverable as shown below
UI Example:
Other Information