nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
557 stars 270 forks source link

Course Planner "Plan to Take" and "Exemptions" sections don't have course autofill feature #3650

Closed dingZvel closed 3 months ago

dingZvel commented 5 months ago

Describe the bug

The "Plan to Take" and "Exemptions" sections don't have the course autofill feature as Year X Semester X sections

To Reproduce

  1. Click the "+ Add Courses" buttons in Exemptions and Plan to Take sections
  2. Type in for example "cs", "ma' or things like that
  3. No completion suggestions will show up for users to autofill.

Expected behavior

Should pop up completion suggestions menu for users to autofill the course, which is the behavior when testing in the above "Year X Semester X" sections

Desktop (please complete the following information):

ravern commented 3 months ago

This probably has something to do with wrong props being passed to the PlannerModuleSelect component.

https://github.com/nusmodifications/nusmods/blob/089993f56557c729572284b762384424f7806d53/website/src/views/planner/AddModule.tsx#L102-L108

I'm labelling this as a good first issue since this seems like a simple UI bug!

ravern commented 3 months ago

I think a tangential issue that can be solved in the same PR is the confusion (because there's no dropdown) that the Add Course button here should be adding the course I enter in the text input.

image

Perhaps something even better would be renaming the text in the button from "Add Course" to "Add Category" or something that avoids this confusion entirely.

kokrui commented 3 months ago

+1 to renaming to "Add Category", I think that's better than adding from the text

wr1159 commented 3 months ago

Hi I am interested in taking this issue