nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
557 stars 270 forks source link

Add Missing Venues to venues.json #3652

Closed EssWhyy closed 5 months ago

EssWhyy commented 5 months ago

Context

Fixes venue update issues from #3588 to #3605

Implementation

Updated venues.json to add missing venue information. There were some duplicate venue data suggestions, so where there were clashes, I added the data in the issue that is added earlier (Issue 1):

Venue Issue 1 Issue 2
HSS-04-07 3589 3591
HSS-04-05 3597 3601
BIZ2-0111 3603 3604

Other Information

Not tested since it seems venues.json needs to be updated on the master branch for the changes to be reflected on the website.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2024 3:33pm
vercel[bot] commented 5 months ago

@EssWhyy is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (70b3c92) 53.20% compared to head (382ce82) 53.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3652 +/- ## ========================================== - Coverage 53.20% 53.18% -0.02% ========================================== Files 272 272 Lines 5885 5885 Branches 1397 1397 ========================================== - Hits 3131 3130 -1 - Misses 2754 2755 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ravern commented 3 months ago

Also closes #3601, #3602, #3603, #3604