Closed JCSnap closed 4 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nusmods-export | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 7, 2024 2:55am |
nusmods-website | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 7, 2024 2:55am |
@JCSnap is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.
@nusmodifications first needs to authorize it.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.70%. Comparing base (
61829ad
) to head (40e4a89
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I also don't love how some courses show up when the border timing range is large, especially in dark mode
but that's for future further discussion where we can build on this work. I also wonder if we can just let the relevant departments know that placeholder timeslots are no longer required (cmiiw)
Context
3658
This is a very short PR.
Implementation
Currently, E-learning module information often use placeholder time since they do not have a fixed time (eg. 0900 - 0901). Since the size of the cell is calculated based on the lesson time, the placeholder time causes the UI to be a bit weird as the calculated background width is short, and the module information is hindered by the UI.
This implementation ensures that the size of the background is at least half the cell:
My initial implementation was to make the cell occupy at least the whole cell but I thought maybe there could be lessons that are just 30 minutes, which is why I changed to such that the minimum is half a cell.