Closed chew01 closed 3 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nusmods-export | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 13, 2024 9:08am |
nusmods-website | 🛑 Canceled (Inspect) | Mar 13, 2024 9:08am |
@chew01 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.
@nusmodifications first needs to authorize it.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.94%. Comparing base (
7494d84
) to head (e97eae7
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Context
Closes #3664
Implementation
Add gradingBasisDescription to ModuleInformation type in scraper (and frontend for consistency) Information is expected to be sent to Elastic client for indexing. Updated view to reflect changes.
Other Information
I'm not familiar with Elastic API and certainly unable to see the endpoint format available so will need core team to review. Let me know if adding field ModuleInformation is insufficient and explicit indexing is required. Thanks 🙌