nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
557 stars 270 forks source link

Fresh install causes warning with @material #3667

Closed woojiahao closed 3 months ago

woojiahao commented 3 months ago

Describe the bug

Fresh install of website/ causes a division warning from the @material/ package.

To Reproduce

Steps to reproduce the behavior:

  1. Fork the repository
  2. Clone the repository
  3. Change to website/
  4. Run installation yarn install
  5. Launch the website with yarn start

Expected behavior

No warnings

Screenshots

Recommendation: math.div(1.05, 0.1376971693)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
41 │   @return max($backLum, $foreLum) / min($backLum, $foreLum);
   │           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    node_modules/@material/theme/_functions.scss 41:11  mdc-theme-contrast()
    node_modules/@material/theme/_functions.scss 52:19  mdc-theme-tone()
    node_modules/@material/theme/_functions.scss 65:14  mdc-theme-contrast-tone()
    node_modules/@material/theme/_variables.scss 32:27  @import
    node_modules/@material/theme/_mixins.scss 23:9      @import
    node_modules/@material/ripple/_mixins.scss 24:9     @import
    node_modules/@material/fab/mdc-fab.scss 22:9        @import
    src/styles/material/material.scss 19:9              @import
    src/styles/main.scss 9:9                            root stylesheet

Deprecation Warning: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Desktop (please complete the following information):

Additional context

NA

woojiahao commented 3 months ago

Appears to be a Sass issue

woojiahao commented 3 months ago

Not a major issue since they're all warnings and any changes to the dependencies result in major breaking changes across the repository. Will be closing this for now unless a major need arises for fixing these warnings