nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
557 stars 270 forks source link

Implement separate flags for CPEx #3669

Closed woojiahao closed 3 months ago

woojiahao commented 3 months ago

Context

Solves #3660

Implementation

enableCPEx == true -> allows users to signin enableCPEx == false -> displays start time showCPExTab == true -> displays CPEx tab on sidebar showCPExTab == false -> removes CPEx tab from sidebar

Other Information

NA

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 9:23am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 9:23am
vercel[bot] commented 3 months ago

@woojiahao is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 53.86%. Comparing base (5945799) to head (bd29cfe).

Files Patch % Lines
website/src/views/mpe/MpeContainer.tsx 0.00% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3669 +/- ## ========================================== - Coverage 53.94% 53.86% -0.09% ========================================== Files 272 272 Lines 5963 5974 +11 Branches 1420 1426 +6 ========================================== + Hits 3217 3218 +1 - Misses 2746 2756 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.