nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
557 stars 270 forks source link

Add unique week check in formatNumericWeeks #3677

Closed jloh02 closed 3 months ago

jloh02 commented 3 months ago

Context

3648

Implementation

TimetableCell formatNumericWeeks does a check to ensure listed weeks are unique. Also update condition for change in week <= 1 instead

Other Information

Instead of simply ensuring unique, should we also sort the weeks and maintain the <= 1 condition?

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 6:54am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 6:54am
vercel[bot] commented 3 months ago

@jloh02 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.62%. Comparing base (711a6da) to head (eba7f1b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3677 +/- ## ========================================== + Coverage 53.60% 53.62% +0.01% ========================================== Files 272 272 Lines 5977 5979 +2 Branches 1428 1428 ========================================== + Hits 3204 3206 +2 Misses 2773 2773 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.