nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
582 stars 316 forks source link

Bug with Odd and Even week .ics exports #3679

Open onx001 opened 6 months ago

onx001 commented 6 months ago

Describe the bug

The ICS exports do not account for recess weeks when calculating odd and even weeks in Google calendar

To Reproduce

Steps to reproduce the behavior:

  1. Add odd/even week slots to timetable
  2. Export timetable as .ics file
  3. Import it on gcal
  4. View slots on ics file after recess weeks
  5. See error in allocating odd/even weeks

Expected behavior

Odd/even week calculation is supposed to exclude the recess week and continue as per normal

Screenshots

image Here google saves it as weekly

image Here it double counts after week 11 due to weeks 12 and 13 not being specified

Offending timetable: https://nusmods.com/timetable/sem-1/share?SC2204=TUT:D1,LEC:1

image Worsened problems on GCal android

kokrui commented 6 months ago

Great catch, and thanks for creating the issue! I can reproduce this

update saturday: nvm, seems to work fine on gcal for me? I feel like I've experienced this before though, but if it works for you too let's close this for now until we figure it out

onx001 commented 6 months ago

Edit: problem has been refined to a specific case for further review and testing. Appears to be a problem with 1. Defining Odd/Even weeks in website/src/utils/ical.ts Possible solution: CSV export format for android google calendar users due to weird ics input reformatting with gcal on android. Update: currently working with modifying ICS export format to be more robust

Noob-No-1 commented 1 month ago

I would like to work on this issue

Noob-No-1 commented 1 month ago

I would like to work on this issue

nvm the issue is alr fixed lmao