search

nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
557 stars 270 forks source link

Set autoFocus for activeLesson #3680

Closed jloh02 closed 3 months ago

jloh02 commented 3 months ago

Context

Fix #3484

Implementation

Set autoFocus on activeLesson. Although this leads to multiple elements with autoFocus, the first one in the DOM will be chosen which would still be an activeLesson button. This allows the onKeyUp event to fire in TimetableContent.tsx

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 7:30am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 7:30am
vercel[bot] commented 3 months ago

@jloh02 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.62%. Comparing base (be22c79) to head (fa2ab42).

Files Patch % Lines
website/src/views/timetable/TimetableContent.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3680 +/- ## ======================================= Coverage 53.62% 53.62% ======================================= Files 272 272 Lines 5979 5979 Branches 1428 1428 ======================================= Hits 3206 3206 Misses 2773 2773 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.