search

nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
557 stars 270 forks source link

Exclude Hidden Modules from being exported into iCal #3682

Closed maverick-g00se closed 3 months ago

maverick-g00se commented 3 months ago

Context

3681

Implementation

Added an extra parameter hiddenModules: string[] to iCalForTimetable function in ical.ts to pass in hidden modules and filter accordingly.

Other Information

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 6:23am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 6:23am
vercel[bot] commented 3 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.61%. Comparing base (e6a32fd) to head (37e0c10).

Files Patch % Lines
website/src/actions/export.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3682 +/- ## ========================================== + Coverage 53.59% 53.61% +0.01% ========================================== Files 272 272 Lines 5974 5976 +2 Branches 1426 1428 +2 ========================================== + Hits 3202 3204 +2 Misses 2772 2772 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.