nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
582 stars 316 forks source link

Fix Course Selection in Planner (Exemptions & Plan to Take) #3683

Closed wr1159 closed 6 months ago

wr1159 commented 6 months ago

Context

Fixes #3650 where users cannot select modules in the "Exemptions" and "Plan to Take" sections of the planner page. Also renamed "Add course" button to "Add Category" to be clearer.

Implementation

Previously AllModules which displays all the modules in AddModule mistakenly filters out all the modules as EXEMPTION_SEMESTER and PLAN_TO_TAKE_SEMESTER had values of -1 and -2 respectively. The proposed change is to prevent filtering by semester in the AddModule for "Exemptions" and "Plan to Take".

Before After
image image
image

Other Information

Hi I am Wei Rong and I am looking forward to contribute more to nusmods!

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2024 8:05am
vercel[bot] commented 6 months ago

@wr1159 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.59%. Comparing base (2f723c6) to head (6968ed5).

Files Patch % Lines
website/src/views/planner/PlannerModuleSelect.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3683 +/- ## ========================================== - Coverage 53.61% 53.59% -0.02% ========================================== Files 272 272 Lines 5974 5974 Branches 1426 1426 ========================================== - Hits 3203 3202 -1 - Misses 2771 2772 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ravern commented 6 months ago

Hi I am Wei Rong and I am looking forward to contribute more to nusmods!

🚀🚀🚀