Closed wr1159 closed 6 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nusmods-export | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 24, 2024 8:05am |
@wr1159 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.
@nusmodifications first needs to authorize it.
Attention: Patch coverage is 0%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 53.59%. Comparing base (
2f723c6
) to head (6968ed5
).
Files | Patch % | Lines |
---|---|---|
website/src/views/planner/PlannerModuleSelect.tsx | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi I am Wei Rong and I am looking forward to contribute more to nusmods!
🚀🚀🚀
Context
Fixes #3650 where users cannot select modules in the "Exemptions" and "Plan to Take" sections of the planner page. Also renamed "Add course" button to "Add Category" to be clearer.
Implementation
Previously
AllModules
which displays all the modules inAddModule
mistakenly filters out all the modules asEXEMPTION_SEMESTER
andPLAN_TO_TAKE_SEMESTER
had values of -1 and -2 respectively. The proposed change is to prevent filtering by semester in theAddModule
for "Exemptions" and "Plan to Take".Other Information
Hi I am Wei Rong and I am looking forward to contribute more to nusmods!