nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
558 stars 270 forks source link

Release Planner #3696

Open wr1159 opened 3 months ago

wr1159 commented 3 months ago

Context

Resolves #3689

Implementation

Description Before After
No more beta toggle image image
Planner tab in mobile navbar image image
No more leave feedback button image image

Other Information

Since there's no more test, the beta test toggle in settings doesn't appear by default anymore. Is this intended?

Noticed that the plan to take, exemptions and trash section overflows for mobile. Should we fix it first before releasing this to public? We can make another issue for it, because it's UI related I think we need some discussion for it.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 0:02am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 0:02am
vercel[bot] commented 3 months ago

@wr1159 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.58%. Comparing base (5774b51) to head (01b7eea).

:exclamation: Current head 01b7eea differs from pull request most recent head 8a50aad. Consider uploading reports for the commit 8a50aad to get more accurate results

Files Patch % Lines
website/src/views/settings/BetaToggle.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3696 +/- ## ========================================== - Coverage 53.58% 53.58% -0.01% ========================================== Files 273 272 -1 Lines 5983 5976 -7 Branches 1429 1426 -3 ========================================== - Hits 3206 3202 -4 + Misses 2777 2774 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kokrui commented 3 months ago

I'll approve this pending merge conflicts and stuff, but merging will be on hold for now due to some internal requirements with NUS. We expect to be able to merge in around a month or so 🙏