search

nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
558 stars 270 forks source link

Planner's "Plan To Take" / "Exemptions" / "Trash" section overflows on mobile #3698

Closed kokrui closed 3 months ago

kokrui commented 3 months ago

Describe the bug

On mobile, the bottom section of the planner which contains the "plan to take", "exemption", and "trash" cards overflows on mobile

This is blocking https://github.com/nusmodifications/nusmods/pull/3696

The "Beta - Send Feedback" button also doesn't really fit on mobile, but that doesn't need to be fixed in this PR (and it doesn't block #3696)

kokrui commented 3 months ago

I think the easiest solution for now (and one I'd approve and merge) would be to make the bottom section left-right scrollable like the top section

Relevant code:

https://github.com/nusmodifications/nusmods/blob/7334b074fc4fee253592418b28528784129c0f3d/website/src/views/planner/PlannerContainer/PlannerContainer.tsx#L221-L227

https://github.com/nusmodifications/nusmods/blob/7334b074fc4fee253592418b28528784129c0f3d/website/src/views/planner/PlannerContainer/PlannerContainer.scss#L53-L63