nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
558 stars 270 forks source link

Fix planner header wrap and center planner settings button cogwheel #3704

Closed jloh02 closed 3 months ago

jloh02 commented 3 months ago

Context

Fix #3703

Implementation

Just CSS changes and removal of margin when "Settings" word removed

Possible Improvements

There's a few UI minor details which I felt could've been done better but considering that we can release the planner then fix these minor things I'm going to leave these points here

Screenshots

370px width with beta button: image

500px width with beta button: image

900px width with beta button: image

1600px width with beta button: image

370px width without beta button: image

500px width without beta button: image

900px width without beta button: image

1600px width without beta button: image

vercel[bot] commented 3 months ago

@jloh02 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 2:49am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 2:49am
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.57%. Comparing base (e2253bd) to head (7d47960).

Files Patch % Lines
...ebsite/src/views/planner/PlannerSettingsButton.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3704 +/- ## ========================================== - Coverage 53.58% 53.57% -0.01% ========================================== Files 273 273 Lines 5983 5984 +1 Branches 1429 1430 +1 ========================================== Hits 3206 3206 - Misses 2777 2778 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kokrui commented 3 months ago

FYI we plan to keep the Beta - Send Feedback button for a sem or two still after releasing the planner! (though maybe change the text to "Send Feedback")