nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
558 stars 270 forks source link

Fix planner appearance and layout #3711

Closed jloh02 closed 2 months ago

jloh02 commented 2 months ago

Context/Implementation

Fix comments from @ZhangYiJiang

Not sure if the negative margin in planner settings dialog close button is sufficient and looks neat enough. Do let me know how to tweak the margins as required thanks!

Screenshots

image image image

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 7:01am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 7:01am
vercel[bot] commented 2 months ago

@jloh02 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.

@nusmodifications first needs to authorize it.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.62%. Comparing base (1e34328) to head (5e22d62).

Files Patch % Lines
...iews/planner/PlannerContainer/PlannerContainer.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3711 +/- ## ========================================== + Coverage 53.57% 53.62% +0.04% ========================================== Files 273 272 -1 Lines 5984 5979 -5 Branches 1430 1428 -2 ========================================== Hits 3206 3206 + Misses 2778 2773 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.