search

nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
558 stars 270 forks source link

Add well-formed timetable validation check #3715

Closed leslieyip02 closed 2 months ago

leslieyip02 commented 2 months ago

Context

Resolves #3673

Implementation

Uses joi to check if export data conforms to PageData.

Other Information

I chose to use this library because it was used in nusmods/scrapers.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 10:06am
vercel[bot] commented 2 months ago

@leslieyip02 is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.57%. Comparing base (fd424d3) to head (ed1aa4f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3715 +/- ## ======================================= Coverage 53.57% 53.57% ======================================= Files 273 273 Lines 5984 5984 Branches 1430 1430 ======================================= Hits 3206 3206 Misses 2778 2778 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.