Closed mongj closed 2 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nusmods-export | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 17, 2024 8:55am |
nusmods-website | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 17, 2024 8:55am |
@mongj is attempting to deploy a commit to the modsbot's projects Team on Vercel.
A member of the Team first needs to authorize it.
Attention: Patch coverage is 64.28571%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 53.60%. Comparing base (
34103d9
) to head (1ae1347
).
Files | Patch % | Lines |
---|---|---|
website/src/views/venues/VenueList.tsx | 0.00% | 3 Missing :warning: |
website/src/views/venues/VenuesContainer.tsx | 60.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Context
Implements #3686
Implementation
searchVenue function is modified to take in an optional VenueLocations argument and filter against both venue and roomName if the optional argument is provided. VenueLocations is made optional for backward compatibility.
venueContainters receive the venueLocations prop from withVenueLocations HOC. venueLocations is then passed to the searchVenue function in venueContainters's render method.
The venue buttons are also modified to show both venue and room names (if present).
Other Information