nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
558 stars 270 forks source link

Include Room Name in Venue Search #3717

Closed mongj closed 2 months ago

mongj commented 2 months ago

Context

Implements #3686

Implementation

searchVenue function is modified to take in an optional VenueLocations argument and filter against both venue and roomName if the optional argument is provided. VenueLocations is made optional for backward compatibility.

venueContainters receive the venueLocations prop from withVenueLocations HOC. venueLocations is then passed to the searchVenue function in venueContainters's render method.

The venue buttons are also modified to show both venue and room names (if present).

Screenshot 2024-04-17 at 4 48 55 PM

Other Information

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 8:55am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 8:55am
vercel[bot] commented 2 months ago

@mongj is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 53.60%. Comparing base (34103d9) to head (1ae1347).

Files Patch % Lines
website/src/views/venues/VenueList.tsx 0.00% 3 Missing :warning:
website/src/views/venues/VenuesContainer.tsx 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3717 +/- ## ========================================== - Coverage 53.62% 53.60% -0.02% ========================================== Files 272 272 Lines 5979 5986 +7 Branches 1428 1433 +5 ========================================== + Hits 3206 3209 +3 - Misses 2773 2777 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.