nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
558 stars 270 forks source link

feat(venues): add highlighting for matched substrings in Venue Search #3722

Closed mongj closed 2 months ago

mongj commented 2 months ago

Context

Implements #3720

Implementation

Implemented using existing highlight function, which is already used for highlighting results in the main search bar in desktop view.

Screenshot 2024-04-18 at 4 23 10 PM

Venue search with highlighting

Screenshot 2024-04-17 at 8 46 20 PM

Other Information

This PR is for the same commits as #3721. I closed #3721 because it was failing to upload the code coverage report which caused the build_and_test check to fail after merging from the master branch (I'm not sure why exactly though).

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview Apr 19, 2024 4:08am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 4:08am
vercel[bot] commented 2 months ago

@mongj is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.59%. Comparing base (512d3e8) to head (79d0d81).

Files Patch % Lines
website/src/views/venues/VenueList.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3722 +/- ## ======================================= Coverage 53.59% 53.59% ======================================= Files 272 272 Lines 5986 5987 +1 Branches 1433 1434 +1 ======================================= + Hits 3208 3209 +1 Misses 2778 2778 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.