Closed ChillinRage closed 2 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
nusmods-export | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 17, 2024 5:06pm |
nusmods-website | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 17, 2024 5:06pm |
@ChillinRage is attempting to deploy a commit to the modsbot's projects Team on Vercel.
A member of the Team first needs to authorize it.
Attention: Patch coverage is 71.42857%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 53.63%. Comparing base (
e6423d8
) to head (6efddc3
).
Files | Patch % | Lines |
---|---|---|
website/src/views/planner/PlannerModule.tsx | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Apologies for the missing message and late response too. I've added the section that should display a warning message. Is there a way in which I can run a live webpage that allows me to test my local changes?
Apologies for the missing message and late response too. I've added the section that should display a warning message. Is there a way in which I can run a live webpage that allows me to test my local changes?
Yes! Once you've cloned the repository, just run cd website
to enter the website folder, yarn install
to install all the dependencies, and then yarn start
to start the web server.
Let me know if that works.
Yes I just tried yarn start
and it works. Thank you!
As for the conflict message, it does appear after the changes.
Duplicate conflict checks if there are modules with the same module code added to the same academic year and semester.
Context
Proposal to fix #3732 which having same modules in the same year/semester shows no warnings.
Implementation
Added a new conflict that checks if the module list for a given semester has more than one module of the same module code.
Other Information
Added test case for the conflict, though I'm slightly confused as to what's the role/difference between
planner
andmoduleBank
(the variables in theplanner.test.ts
)?