search

nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
586 stars 319 forks source link

Scroll to top only after page has loaded #38

Closed thebengeu closed 9 years ago

thebengeu commented 10 years ago

Minor visual bug when switching to pages which load asynchronously.

Example:

  1. Start session from http://nusmods.com/modules
  2. Scroll down
  3. Switch to timetable which has some modules

Scroll bar will appear to jump to top then disappear when page has loaded. It should simply stay in position, then disappear once page loads.

yangshun commented 9 years ago

Seems to be working fine for the modules to timetable page navigation now. However, this behaviour still exists via these steps:

  1. Start session from a module page such as http://nusmods.com/modules/ACC1002.
  2. Search for a module in the top bar.
  3. Press enter for any other module.

The page will jump to the module but scroll position isn't at the top.

yangshun commented 9 years ago

Fixed via #158.