search

nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
589 stars 320 forks source link

Fix SASS deprecation warnings during build #3819

Open zwliew opened 2 months ago

zwliew commented 2 months ago

Currently, when building the web app with yarn build, the build process spews a lot of warnings, mostly regarding deprecated SASS features.

Any help with fixing these deprecation warnings is much appreciated!

shiva-karthick commented 1 month ago

Hi, I would like to take up this issue. :) May I please confirm if the previous references satisfy this PR?

ravern commented 1 month ago

May I please confirm if the previous references satisfy this PR?

Can I clarify what you mean?

The previous PR does make some progress towards reducing the warnings produced, but there are still some warnings that require more significant changes to fix, which are detailed in #3823 PR description. Also, we're not accepting PRs that silence the warnings, which was why #3820 was closed.

That being said, you're welcome to take up this PR!