nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
590 stars 319 forks source link

fix(venues): resolve mismatched selected time period #3822

Closed Beebeeoii closed 2 months ago

Beebeeoii commented 2 months ago

Context

This PR closes https://github.com/nusmodifications/nusmods/issues/3821.

Implementation

For context, this was probably broken because of the added support for 15-min intervals (https://github.com/nusmodifications/nusmods/pull/3771) which caused there to be 4 periods in a single hour. This PR resolves the issue by replacing the hard-coded number of periods in an hour.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 1:20am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 1:20am
vercel[bot] commented 2 months ago

@Beebeeoii is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.60%. Comparing base (2d4743d) to head (21d5674). Report is 25 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3822 +/- ## ========================================== + Coverage 53.87% 54.60% +0.72% ========================================== Files 274 274 Lines 6032 6053 +21 Branches 1449 1446 -3 ========================================== + Hits 3250 3305 +55 + Misses 2782 2748 -34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zwliew commented 2 months ago

Thanks!