nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
589 stars 320 forks source link

Fix Add Course button in timetable misalignment #3829

Closed kaze-droid closed 1 month ago

kaze-droid commented 2 months ago

Context

Fix for Issue #3827

Implementation

Added additional css styling for small and medium media breakpoint in Modals.scss and ModulesSelect.scss

Other Information

Before: Modules select tip not visible in Small breakpoint

Before Small Breakpoint

Before: Modules select downshift component not properly aligned in Medium breakpoint

Before Medium Breakpoint

After for Small & Medium:

After Small Breakpoint

After Medium Breakpoint

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
nusmods-export βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 30, 2024 7:59am
nusmods-website βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 30, 2024 7:59am
vercel[bot] commented 2 months ago

@kaze-droid is attempting to deploy a commit to the modsbot's projects Team on Vercel.

A member of the Team first needs to authorize it.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.63%. Comparing base (2d4743d) to head (2dc8861). Report is 32 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3829 +/- ## ========================================== + Coverage 53.87% 54.63% +0.75% ========================================== Files 274 274 Lines 6032 6066 +34 Branches 1449 1453 +4 ========================================== + Hits 3250 3314 +64 + Misses 2782 2752 -30 ``` | [Flag](https://app.codecov.io/gh/nusmodifications/nusmods/pull/3829/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nusmodifications) | Coverage Ξ” | | |---|---|---| | [](https://app.codecov.io/gh/nusmodifications/nusmods/pull/3829/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nusmodifications) | `54.63% <ΓΈ> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nusmodifications#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.