nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
589 stars 320 forks source link

Update error message for unexpected auth errors #3836

Closed jloh02 closed 1 month ago

jloh02 commented 1 month ago

Context

"Unexpected error occurred" message occurs when login via NUS using email passes but no relayState given by NUS API

Implementation

Return additional info by overriding defaultRescue handler

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 3:08pm
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 3:08pm
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.86%. Comparing base (2d4743d) to head (aa059c2). Report is 38 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3836 +/- ## ========================================== + Coverage 53.87% 54.86% +0.98% ========================================== Files 274 274 Lines 6032 6066 +34 Branches 1449 1453 +4 ========================================== + Hits 3250 3328 +78 + Misses 2782 2738 -44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.