nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
575 stars 300 forks source link

NUSMods broken on Firefox 30.0 for me #49

Closed wgx731 closed 10 years ago

wgx731 commented 10 years ago

Please see the below screen print for details. error_page

Wish you can resolve it soon. Thank you very much. :smile:

thebengeu commented 10 years ago

Thanks for reporting, this might be a duplicate or related to what @lowjoel reported in #23. Had hoped it might be somehow unique to his setup. We figured out that it's because IndexedDB can't be used somehow, but not sure why. Is this on Windows?

Could it be due to privacy settings? http://stackoverflow.com/questions/14082932/invalid-state-error-in-firefox-for-indexed-db

Also, could you check against http://www.html5rocks.com/en/tutorials/indexeddb/todo/ and see if the example at the bottom works? Thanks!

wgx731 commented 10 years ago

Hi @ahbeng,

I am on Ubuntu with Firefox 30, the problem occurs only in private browsing mode for me. So I think it's related to Limitations of IndexedDB. And maybe you can merge this with #23 but in my case, the page just can't load due to the JavaScript issue.

Thank you very much for the quick response, and wish you can solve the problem with above details.

Best Regards, GaoXiang

thebengeu commented 10 years ago

Yeah just tried it out myself and I see that too. Should be able to solve, thanks for confirming!

@lowjoel could you check if yours is due to privacy settings too?

lowjoel commented 10 years ago

IIRC mine was set to "remember history". But I'll check when I'm home.

thelazychicken93 commented 10 years ago

I'm using Firefox 30.0 on Windows 8.1 (64-bit). Works fine for me. Could it be due to extensions such as NoScript? My Firefox currently does not have any extensions.

lowjoel commented 10 years ago

@ahbeng confirmed that history is set to "Remember History".

thebengeu commented 10 years ago

Relevant Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=781982

Fixed localForage such that it falls back on localStorage.

@wgx731 @lowjoel can you verify that it's fixed? Thanks!

lowjoel commented 10 years ago

Yup, it works. Thanks.

thebengeu commented 10 years ago

Todo: switch back to official build if mozilla/localForage#207 is merged.

wgx731 commented 10 years ago

@ahbeng It works on my side as well. Thanks.