nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
578 stars 315 forks source link

Improve header UI on mobile #527

Closed ZhangYiJiang closed 6 years ago

ZhangYiJiang commented 6 years ago

The current two row v3 mobile header takes up too much space. I'm opening the discussion to what we can do to improve it

For the space problem, I see three possible solutions

Comments?

taneliang commented 6 years ago

I don't like the idea of using React Headroom - they've always felt annoying because they'll jump in your face the moment you scroll up. I'd say that sticky only navtabs is the best solution but it may still be too tall on landscape mobile though.

Also it may be acceptable not to sticky the header on iPhones as you can still scroll to the top easily, but having an exception for one platform is probably not the best way to go.