search

nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
586 stars 319 forks source link

Export image button does not work on Microsoft Edge #592

Closed yunpengn closed 6 years ago

yunpengn commented 6 years ago

Nothing changes after clicking the export image button.

Open the console, see the following error message: image

The export iCal button does not work as well.

ZhangYiJiang commented 6 years ago

Can reproduce. I remembered @li-kai using msSaveBlob in #575 at some point, but that doesn't seem to be there anymore so that PR doesn't solve this, hmmm.

ZhangYiJiang commented 6 years ago

May be related: https://sentry.io/nusmods/v3/issues/424358674/

yangshun commented 6 years ago

Hey @yunpengn , thanks for the bug report. Could you share with us why you have the need to export the timetable at this point of time?

Trying to understand user behavior here 😄

yunpengn commented 6 years ago

I use this feature in the old version of NUSMods quite frequently. Basically, I prefer to view my timetable as a local file rather than open the browser. This is more like personal preference though 😄

yangshun commented 6 years ago

I see, got it! Because I was thinking no one would export since their timetable hasn't been finalized yet. We'll look into it soon (:

ZhangYiJiang commented 6 years ago

575 doesn't seem to solve this for me. We may need #596 to solve this.

ZhangYiJiang commented 6 years ago

Fixed by #623