search

nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
586 stars 319 forks source link

Pulsing TimetableCell overlapped by the day name cell #600

Closed kiangkuang closed 6 years ago

kiangkuang commented 6 years ago

The selected TimetableCell is overlapped by the day name cell during pulse animations image

ZhangYiJiang commented 6 years ago

Thanks for reporting this! I agree that this visual blemish is slightly annoying. However, fixing this is non-trivial, as the module also needs to stay under the day name when the timetable is scrolled to the right, which means a pure CSS solution isn't possible.

If you would like to help us with this, we can help you get set up - just drop into our Telegram group and talk to us. Thanks!

kiangkuang commented 6 years ago

Ah, I see the dilemma. I will see if I can do a JS solution where the z-index is set higher only while not scrolled right to keep the current scrolling behavior intact.

ZhangYiJiang commented 6 years ago

Sure. You might want to start with the <Timetable> and <TimetableDay> components in https://github.com/nusmodifications/nusmods/tree/master/v3/src/js/views/timetable

taneliang commented 6 years ago

Fixed by #616