search

nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
575 stars 300 forks source link

Left/right keyboard shortcuts scroll page on smaller widths #64

Closed thebengeu closed 10 years ago

thebengeu commented 10 years ago

It's pretty minor, but are there any intuitive alternatives? H/L wouldn't be intuitive for non-Vim users. Maybe [/]?

yangshun commented 10 years ago

Is there a need to preserve the page scrolling functionality? Was thinking of disabling arrow keys to scroll.

thebengeu commented 10 years ago

Maybe for accessibility for someone with a disability for whom it's hard to use a mouse? But rearranging the timetable is very mouse-driven anyway. I guess more on the basis that it's not very good practice to override default keyboard shortcuts.

yangshun commented 10 years ago

So take away left/right totally and replace with [/] ?

thebengeu commented 10 years ago

Either that or prevent the default scrolling action - left/right was originally ok cos it was confined to the preferences screen.

yangshun commented 10 years ago

If it's on the basis that it's not very good practice to override default keyboard shortcuts (which I totally agree), I would say to disable default scrolling action in this situation. I think it is okay for web apps to override default keyboard shortcuts because the timetable page serves as an app, a tool, and not really as a typical website which serves to display content.

Besides, it's becoming a trend for web apps be filled with shortcuts and overriding shortcuts can become unavoidable. Google docs overrides a default browser keyboard shortcut such as ctrl+S (saving). Asana uses cmd+up/cmd+down to shift tasks and up/down to navigate between tasks. https://asana.com/guide/learn/tags-email/keyboard.

On Wed, Jul 16, 2014 at 10:36 AM, Beng Hee Eu notifications@github.com wrote:

Either that or prevent the default scrolling action - left/right was originally ok cos it was confined to the preferences screen.

— Reply to this email directly or view it on GitHub https://github.com/ahbeng/NUSMods/issues/64#issuecomment-49117348.