search

nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
575 stars 300 forks source link

Facebook like box does not change light/dark mode along with page #69

Closed thebengeu closed 10 years ago

thebengeu commented 10 years ago

https://developers.facebook.com/docs/plugins/like-box-for-pages

ashrayjain commented 10 years ago

The Facebook like box color schemes are broken. All the links in the dark mode are changed to white. What this means is that any links in the actual posts are not visible, due to the white background in the posts. Can give it a try here https://developers.facebook.com/docs/plugins/like-box-for-pages Change the Facebook Page URL field to https://www.facebook.com/NUSMods and see for yourself.

yangshun commented 10 years ago

Heh good discovery @ashrayjain . Seems better to keep it in the light color scheme then.

ashrayjain commented 10 years ago

haha, yea. i was actually considering kicking out the like box altogether in favour of a custom solution for page updates and the facebook like "button" instead.

yangshun commented 10 years ago

Haha don't worry, the box is there to get people to like it during this period where there will be high amount of usage. I don't intend to leave it there forever. Will remove it after the semester starts + build a custom page for updates

thebengeu commented 10 years ago

Shall we close this as unfixable for now then?

yangshun commented 10 years ago

Sounds right