nusmodifications / nusmods

🏫 Official course planning platform for National University of Singapore.
https://nusmods.com
MIT License
586 stars 319 forks source link

Exporting .ics rounds down :30 timings to the nearest hour #724

Closed louietyj closed 6 years ago

louietyj commented 6 years ago

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

Exporting .ics rounds down :30 timings to the nearest hour

If the current behavior is a bug, please provide the steps to reproduce. If possible, please upload a screenshot or link to a video recording (on macOS you can use QuickTime) demonstrating the problem.

  1. From a clean slate, add CS5330 (lecture at 6.30pm).
  2. Export .ics
  3. Observe that the lecture timing on the .ics file is wrongly represented as 6pm and not 6.30pm

image

What is the expected behavior?

Should be 6.30pm.

Further information

ZhangYiJiang commented 6 years ago

Fixed and deployed. Close all open tabs and refresh a few times, and this should work now