Closed dlipovetsky closed 11 months ago
Hi @dlipovetsky. Thanks for your PR.
I'm waiting for a nutanix-cloud-native member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c136d25
) 13.62% compared to head (7fe7c97
) 13.62%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/lgtm
I had to rebase on main. I did that, and force-pushed. There were no rebase conflicts.
/lgtm /approve
I had to rebase again, but this time I used GitHub's "built-in" rebase, and existing approvals were not revoked.
Well, adding a fixup commit dismissed all the reviews, except one. So I decided to squash the fixup commit now, rather than wait for later.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dkoshkin, dlipovetsky, supershal, thunderboltsid
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it: The dev docs rely on the clusterctl executable, as do some make targets. The clusterctl version should correspond to the cluster-api go module dependency version.
I expect this change to make it easier to follow the developer documentation.
If we like this approach for clusterctl, we can also consider it for kind, and even kubectl.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #How Has This Been Tested?:
Here's output of running a make target that depends on clusterctl:
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: